Fix #184: Add support for the Push API

[kapunga]

I did not include any of the following:

• Any item marked deprecated in MDN.

[kapunga]

Question wrt Push API methods in ServiceWorker. Once ServiceWorkers are moved into experimental, should developers still be required to import push package implicits to access fields like ServiceWorkerRegistration.pushManager, or is it assumed once you are using experimental packages, you are using all of them?

[mseddon]

In general, users should enable experimental features per api, rather than as a whole. For example, ServiceWorkers are supported by Opera, but the Push API is not.

[kapunga]

Thanks a lot for the feedback! I'll get to work tweaking things.

[kapunga]

Question:
What do we do when there is something defined to either accept or return an enum like this?

enum PushEncryptionKeyName { "p256dh", "auth" }; 

It seems you could offer additional safety by using an enum, but I couldn't find an example in the code and there doesn't seem to be any reference to such things here:
[[http://www.scala-js.org/doc/interoperability/facade-types.html]]

[sjrd]

scala-js-dom/src/main/scala/org/scalajs/dom/crypto/Crypto.scala

Lines 872 to 887 in 87ab4d7

	/**
	* See [[http://www.w3.org/TR/WebCryptoAPI/#cryptokey-interface ¶ 13. CryptoKey Interface]] of w3c spec
	*/
	@js.native
	trait KeyUsage extends js.Any
	object KeyUsage {
	val encrypt = "encrypt".asInstanceOf[KeyUsage]
	val decrypt = "decrypt".asInstanceOf[KeyUsage]
	val sign = "sign".asInstanceOf[KeyUsage]
	val verify = "verify".asInstanceOf[KeyUsage]
	val deriveKey = "deriveKey".asInstanceOf[KeyUsage]
	val deriveBits = "deriveBits".asInstanceOf[KeyUsage]
	val wrapKey = "wrapKey".asInstanceOf[KeyUsage]
	val unwrapKey = "unwrapKey".asInstanceOf[KeyUsage]
	}

[kapunga]

Thanks.

[mseddon]

Optional parameter, so declare the parameters here as (options: PushSubscriptionOptions = js.native)

[mseddon]

That's all from my end. If you change the commit message to "Fix #184: Add support for the Push API", the related issue will automatically close on merge.

[kapunga]

@mseddon I was waiting for #187 to close, since I was waiting on an interface there. Pushing it now.

[mseddon]

LGTM, thanks! @sjrd will take it from here.

[sjrd]

This should probably be a val

[sjrd]

That's all.

[kapunga]

@mseddon @sjrd Thanks! Just double checked it, it should be done!

[sjrd]

LGTM