Skip to content

Conversation

@mseddon
Copy link
Contributor

@mseddon mseddon commented Nov 5, 2015

Horay, union types! :)

@mseddon
Copy link
Contributor Author

mseddon commented Nov 5, 2015

Okay that failure was travis's fault (the spurious connectivity issues it has from time to time), but this 'one character' PR that I didn't verify is also firing warnings everywhere over the omission of @js.native, duh. Now I see why the version was held back :P

I'll fix this up fully tommorrow.

@mseddon
Copy link
Contributor Author

mseddon commented Nov 5, 2015

image

@mseddon
Copy link
Contributor Author

mseddon commented Nov 5, 2015

That's all, hopefully, appears to work against my projects at least.

@sjrd
Copy link
Member

sjrd commented Nov 5, 2015

so I hoisted it for lack of a better solution.

I did not understand that.

@mseddon
Copy link
Contributor Author

mseddon commented Nov 5, 2015

Just adding a @js.native annotation to VibrationNavigator raised that error, so I moved the definition out of the Vibration object to toplevel, which kept the compiler happy. It does mean it now sits outside of the Vibration object, which isn't as organised, but no harm done. It doesn't need a @JSName annotation really, because it's just a pimp.

@sjrd
Copy link
Member

sjrd commented Nov 5, 2015

Oh. It should be kept where it was, but make it a trait instead, if it's a pimp.

@mseddon
Copy link
Contributor Author

mseddon commented Nov 5, 2015

Ah, right! nice, I'll do that, then. Particularly since this is what I point people to who want to add to experimental ^^

@mseddon mseddon force-pushed the update-scalajs-version branch from caea9e2 to 8852c47 Compare November 5, 2015 19:57
@mseddon
Copy link
Contributor Author

mseddon commented Nov 5, 2015

Squashed together with a less silly commit message, since the initial commit would leave us in a broken state.

@mseddon
Copy link
Contributor Author

mseddon commented Nov 5, 2015

Hmm, shall we update the scala versions to 2.10.6 and 2.11.7 while we're at it?

@mseddon mseddon force-pushed the update-scalajs-version branch from 8852c47 to 91c8937 Compare November 5, 2015 20:03
@mseddon
Copy link
Contributor Author

mseddon commented Nov 5, 2015

Just fixed a formatting issue with Vibration API. Holding off library version change for now.
I'll tweak those too tomorrow, if you like.

@sjrd
Copy link
Member

sjrd commented Nov 5, 2015

Hmm, shall we update the scala versions to 2.10.6 and 2.11.7 while we're at it?

Yes, you can do that as well.

@sjrd
Copy link
Member

sjrd commented Nov 5, 2015

Fix #163: Bump scala-js to 0.6.5 and @js.native everything.

Please spell "Scala.js" the right way ^^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EOL at EOF.

@mseddon mseddon force-pushed the update-scalajs-version branch 2 times, most recently from af8fdec to 51d06e6 Compare November 5, 2015 20:57
@mseddon
Copy link
Contributor Author

mseddon commented Nov 5, 2015

Please spell "Scala.js" the right way ^^

cough. Whoops. :)

@sjrd sjrd changed the title Fix #163: Bump scala-js to 0.6.5. Fix #163: Bump Scala.js to 0.6.5 and @js.native everything. Nov 6, 2015
@sjrd
Copy link
Member

sjrd commented Nov 6, 2015

That's all.

@mseddon mseddon force-pushed the update-scalajs-version branch from 51d06e6 to 10f573a Compare November 6, 2015 10:33
@sjrd
Copy link
Member

sjrd commented Nov 6, 2015

LGTM, thanks :)

sjrd added a commit that referenced this pull request Nov 6, 2015
Fix #163: Bump Scala.js to 0.6.5 and @js.native everything.
@sjrd sjrd merged commit d80ee58 into scala-js:master Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants