Skip to content

Conversation

@japgolly
Copy link
Contributor

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you wrap these docs at 80 characters, please? It's too long to read on mobile.

@sjrd
Copy link
Member

sjrd commented Aug 31, 2015

That's all.

@japgolly
Copy link
Contributor Author

No worries, I'll make both changes shortly.

About constant-folding, didn't you say a while back that it only applied to primitives? Is String an exception to that?

@sjrd
Copy link
Member

sjrd commented Aug 31, 2015

Yes, String is considered a "primitive". As well as classOf[C], IIRC.
Actually it would be more accurate to say literals rather primitives. 10, 5.4d, "hello" and classOf[String] are all literals. But 5.toByte isn't.

@japgolly
Copy link
Contributor Author

japgolly commented Sep 1, 2015

Ahhh that makes a lot of sense. After learning macros somewhat I imagine it's probably Literal(Constant(…)) that are foldable? When you said primitives, I was thinking in the Java sense so no AnyRef subtypes which I thought excluded java.lang.String.

Anyhoo, changes are done. Please take another look.

(Also as requested, I trimmed the comments to line-length 80 but they're now obviously inconsistent with the rest of the file which seems to be around 94. But as you wish. 👐 )

@sjrd
Copy link
Member

sjrd commented Sep 2, 2015

LGTM

sjrd added a commit that referenced this pull request Sep 2, 2015
Add constants for legal DragEffect values
@sjrd sjrd merged commit daa08ce into scala-js:master Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants