Skip to content

Conversation

@mseddon
Copy link
Contributor

@mseddon mseddon commented Jul 8, 2015

Get the ball rolling with org.scalajs.dom.experimental. by adding the vibration api

@mseddon mseddon force-pushed the experimental-vibration-api branch 2 times, most recently from ebb2583 to 49049be Compare July 8, 2015 18:12
@mseddon
Copy link
Contributor Author

mseddon commented Jul 8, 2015

... actually remembered to commit working version and unbork commit message. sigh.

@mseddon
Copy link
Contributor Author

mseddon commented Jul 8, 2015

[error] SERVER ERROR: Connection timed out url=https://repo1.maven.org/maven2/org/scala-lang/scala-library/2.11.6/scala-library-2.11.6.pom

Jenkins network connectivity issue? This test needs to be re-run. :(

@mseddon mseddon force-pushed the experimental-vibration-api branch from 49049be to cb3df00 Compare July 8, 2015 18:27
@mseddon mseddon force-pushed the experimental-vibration-api branch from cb3df00 to f3f2b03 Compare July 10, 2015 17:15
@mseddon
Copy link
Contributor Author

mseddon commented Jul 10, 2015

Implicit conversion now has zero overhead, thanks to advice from @gzm0. I've confirmed this by looking at compiler output in fastOptJS. Okay to merge pending review, but no mad rush :)

lihaoyi added a commit that referenced this pull request Jul 25, 2015
@lihaoyi lihaoyi merged commit 90c845a into scala-js:master Jul 25, 2015
@lihaoyi
Copy link
Contributor

lihaoyi commented Jul 25, 2015

Thanks! =D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants