Skip to content

Improve ClipboardEvent type saftey. #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2015
Merged

Improve ClipboardEvent type saftey. #117

merged 1 commit into from
Jun 2, 2015

Conversation

@mseddon
Copy link
Contributor

@mseddon mseddon commented May 14, 2015

No description provided.

@mseddon mseddon force-pushed the clipboard-event-init branch from 11dc330 to 9f75d0c Compare May 14, 2015 11:23
sjrd
sjrd reviewed May 14, 2015
View reviewed changes
src/main/scala/org/scalajs/dom/raw/lib.scala Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs = js.native.
@sjrd
Copy link
Member

sjrd commented May 14, 2015

There's also a typo in the commit message (saftey).
That's all.
@mseddon mseddon force-pushed the clipboard-event-init branch from 9f75d0c to 76f617b Compare May 14, 2015 11:38
@mseddon
Improve ClipboardEvent type safety.
c3a29d3 
Improve ClipboardEvent type saftey.
@mseddon mseddon force-pushed the clipboard-event-init branch from 76f617b to c3a29d3 Compare May 14, 2015 11:41
@mseddon mseddon mentioned this pull request May 31, 2015
Closed
@sjrd
Copy link
Member

sjrd commented Jun 2, 2015

LGTM
sjrd added a commit that referenced this pull request Jun 2, 2015
@sjrd
Merge pull request #117 from mseddon/clipboard-event-init
4db82fb 
Improve ClipboardEvent type saftey.
@sjrd sjrd merged commit 4db82fb into scala-js:master Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mseddon @sjrd