Skip to content

Keycode changes #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2015
Merged

Keycode changes #109

merged 3 commits into from
Apr 22, 2015

Conversation

@japgolly
Copy link
Contributor

@japgolly japgolly commented Apr 22, 2015

  • Added key codes F1~F12
  • Made KeyCodes camel-case
  • Changed val to final val

Addresses #103 and #104.
Supersedes #105.
@japgolly japgolly mentioned this pull request Apr 22, 2015
Closed
@sjrd
Copy link
Member

sjrd commented Apr 22, 2015

OK. Could you just rename the commit messages to use the present tense, i.e., Made -> Make and Added -> Add.
That's all.

Tip to do so quickly: git rebase -i master and use reword instead of pick for each commit.
@japgolly
Copy link
Contributor Author

japgolly commented Apr 22, 2015

You make me feel like a hamster on a wheel @sjrd. How about now? 🙏
@sjrd
Copy link
Member

sjrd commented Apr 22, 2015

LGTM :)
sjrd added a commit that referenced this pull request Apr 22, 2015
@sjrd
Merge pull request #109 from japgolly/keycode
407f033 
Keycode changes
@sjrd sjrd merged commit 407f033 into scala-js:master Apr 22, 2015
@japgolly
Copy link
Contributor Author

japgolly commented Apr 22, 2015

we did it! Thank you 🌞
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@japgolly @sjrd