Skip to content

Node: Fix calls to insertBefore() with one argument #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2015
Merged

Node: Fix calls to insertBefore() with one argument #100

merged 1 commit into from
Mar 8, 2015

Conversation

@tindzk
Copy link
Contributor

@tindzk tindzk commented Mar 8, 2015

No description provided.

@sjrd
Copy link
Member

sjrd commented Mar 8, 2015

Actually, MDN says that both arguments are required. The default value should therefore be removed altogether.
@sjrd
Copy link
Member

sjrd commented Mar 8, 2015

Note that the value put after = doesn't matter to the compiler in a JS facade. It only serves documentation purposes. So putting null there will not make the compiler add a null if you don't specify the second argument.
@tindzk
Copy link
Contributor Author

tindzk commented Mar 8, 2015

Ok, thanks for clearing this up. I updated the commit accordingly.
@sjrd
Copy link
Member

sjrd commented Mar 8, 2015

LGTM, thanks.
sjrd added a commit that referenced this pull request Mar 8, 2015
@sjrd
Merge pull request #100 from tindzk/insertbefore
f0a5a64 
Node: Fix calls to insertBefore() with one argument
@sjrd sjrd merged commit f0a5a64 into scala-js:master Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@tindzk @sjrd