Update function name in "Don't add unneeded context" #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| Oo thanks for looking at this, it seems we could actually modify this function to be: function paintCar(car, color) { car.color = color; }Would you have the chance to add a second commit to your PR to make the function look like that? |
Author
| Definitely! I wanted to just make the smallest change possible, but I agree that a function that only paints a car red quite specific! |
felquis approved these changes Jul 16, 2017
felquis left a comment
felquis left a comment There was a problem hiding this comment.
Okay guys, so this PR is really good and can be merged without thinking twice!
Owner
| Fixed in 3ff9eba |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Was reading through the README and spotted the function name in "Don't add unneeded context" breaks the rule "Function names should say what they do". Want to throw a quick PR up for you!
Thanks!