add address sanitizer for android #94601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added the T-compiler 
Contributor
|
rust-highfive added the S-waiting-on-review 
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
| Could you add a description to the PR which would explain why it is fine to enable these now (i.e. you tested it/support has been implemented in… etc?) and maybe even a link to https://source.android.com/devices/tech/debug/asan. Implementation wise this LGTM (r=me) |
nagisa added S-waiting-on-author 
Contributor Author
| r? @nagisa edited. |
Member
| @bors r+ |
Collaborator
| 📌 Commit 6d41565 has been approved by |
bors added S-waiting-on-bors Collaborator
Collaborator
| ☀️ Test successful - checks-actions |
csmoe changed the title 
Collaborator
| Finished benchmarking commit (0cbef1c): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We have been being using asan to debug the rust/cpp/c mixed android application in production for months: recompile the rust library with a patched rustc, everything just works fine. The patch is really small thanks to @nagisa 's refactoring in #81866
r? @nagisa