Fix horizontal trim for block doc comments #93715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GuillaumeGomez added the T-rustdoc 
rustbot added the T-compiler 
rust-highfive added the S-waiting-on-review 
This comment has been minimized.
This comment has been minimized.
notriddle reviewed Feb 6, 2022
GuillaumeGomez force-pushed the horizontal-trim branch from 917aa44 to 4553fc8 Compare 
| Should be better now. :) |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez force-pushed the horizontal-trim branch from 4553fc8 to a476ec8 Compare | With fmt it's better. :) |
| @bors r+ rollup |
| 📌 Commit a476ec8 has been approved by |
bors added S-waiting-on-bors notriddle approved these changes Feb 7, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#86497 (Add {floor,ceil}_char_boundary methods to str) - rust-lang#92695 (Add `#[no_coverage]` tests for nested functions) - rust-lang#93521 (Fix hover effects in sidebar) - rust-lang#93568 (Include all contents of first line of scraped item in Rustdoc) - rust-lang#93569 (rustdoc: correct unclosed HTML tags as generics) - rust-lang#93672 (update comment wrt const param defaults) - rust-lang#93715 (Fix horizontal trim for block doc comments) - rust-lang#93721 (rustdoc: Special-case macro lookups less) - rust-lang#93728 (Add in ValuePair::Term) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
| @GuillaumeGomez but the time is not always 0.00s, it sometimes takes longer. |
| Good catch! Sending a fix right away! |
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 3, 2022
…-test, r=petrochenkov Fix flaky rustdoc-ui test because it did not replace time result As mentioned in rust-lang#93715: a test is flaky because I forgot to replace the time value. This PR fixes it. r? `@petrochenkov`
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 4, 2022
…-test, r=petrochenkov Fix flaky rustdoc-ui test because it did not replace time result As mentioned in rust-lang#93715: a test is flaky because I forgot to replace the time value. This PR fixes it. r? ``@petrochenkov``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #93662.
Fixes #93309.
r? @notriddle