Skip to content

Update chalk to 0.75.0 #92167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2021
Merged

Update chalk to 0.75.0 #92167

merged 2 commits into from
Dec 23, 2021

Conversation

@pierwill
Copy link
Contributor

@pierwill pierwill commented Dec 21, 2021 •
edited
Loading

  • Compute flags in intern_ty
  • Remove tracing-serde from PERMITTED_DEPENDENCIES
  • Bump tracing-tree to 0.2.0
  • Bump tracing-subscriber to 0.3.3
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 21, 2021
@rust-highfive
Copy link
Contributor

rust-highfive commented Dec 21, 2021

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2021
@pierwill pierwill marked this pull request as draft December 21, 2021 18:16
@pierwill
Copy link
Contributor Author

pierwill commented Dec 21, 2021

@rustbot author
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jackh726
Copy link
Member

jackh726 commented Dec 21, 2021

r? @jackh726
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pierwill pierwill changed the title Update chalk to 0.70.0 Update chalk to 0.75.0 Dec 21, 2021
@pierwill pierwill marked this pull request as ready for review December 21, 2021 20:26
jackh726
jackh726 requested changes Dec 21, 2021
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments. And can you squash the commits?
@pierwill pierwill force-pushed the chalk-update branch 3 times, most recently from 8d22c89 to 4b37963 Compare December 21, 2021 22:16
@pierwill
Copy link
Contributor Author

pierwill commented Dec 21, 2021

@rustbot ready
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 21, 2021
jackh726
jackh726 approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the lock file additions are reverted
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 22, 2021
@pierwill pierwill requested a review from jackh726 December 22, 2021 16:02
@pierwill
Copy link
Contributor Author

pierwill commented Dec 22, 2021

Regarding rustdoc, @jyn514 approved the tracing-tree version upgrade.
@pierwill
Update chalk to 0.75.0
ea25b77 
- Compute flags in `intern_ty` - Remove tracing-serde from PERMITTED_DEPENDENCIES - Disable `tracing-full` feature in `chalk-solve` - Bump tracing-tree to 0.2.0
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jackh726
Copy link
Member

jackh726 commented Dec 22, 2021

@bors r+
@bors
Copy link
Collaborator

bors commented Dec 22, 2021

📌 Commit 155a4a8 has been approved by jackh726
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2021
@bors
Copy link
Collaborator

bors commented Dec 23, 2021

⌛ Testing commit 155a4a8 with merge c1d301b...
@bors
Copy link
Collaborator

bors commented Dec 23, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing c1d301b to master...
@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 23, 2021
@bors bors merged commit c1d301b into rust-lang:master Dec 23, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 23, 2021
@bors bors mentioned this pull request Dec 23, 2021
Merged
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 23, 2021

Finished benchmarking commit (c1d301b): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression
@pierwill pierwill deleted the chalk-update branch December 28, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

8 participants

@pierwill @rust-highfive @rust-log-analyzer @jackh726 @bors @rust-timer @Mark-Simulacrum @rustbot