Fix clippy lints in librustdoc #89430
Conversation
GuillaumeGomez added C-cleanup 
There was a problem hiding this comment.
Calling len() on a string is cheap. This seems like a poor suggestion.
There was a problem hiding this comment.
Micro optimization one would say: String::len calls self.vec.len() (which simply returns its len field). Well, lint fixed at least haha.
There was a problem hiding this comment.
@GuillaumeGomez can you please revert this? I don't think it's an improvement.
There was a problem hiding this comment.
It was reverted already. ;)
GuillaumeGomez force-pushed the rustdoc-clippy-lints branch from 6129eec to 0260a10 Compare GuillaumeGomez added the S-waiting-on-review GuillaumeGomez force-pushed the rustdoc-clippy-lints branch from 0260a10 to 7d0808e Compare 
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez force-pushed the rustdoc-clippy-lints branch from 7d0808e to 6201163 Compare This comment has been minimized.
This comment has been minimized.
GuillaumeGomez force-pushed the rustdoc-clippy-lints branch 2 times, most recently from f7b1ef0 to b0d8544 Compare 
| Updated! I also reverted some changes too as discussed previously. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez force-pushed the rustdoc-clippy-lints branch from b0d8544 to 1a6e35e Compare This comment has been minimized.
This comment has been minimized.
GuillaumeGomez force-pushed the rustdoc-clippy-lints branch from 1a6e35e to 29d3e9b Compare | Updated! |
| ☔ The latest upstream changes (presumably #90203) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez force-pushed the rustdoc-clippy-lints branch from 29d3e9b to 4614ca4 Compare | Rebased. |
| Since I reverted everything that needed to be, let's move forward! @bors: r=jyn514,camelid,notriddle |
| 📌 Commit 4614ca4 has been approved by |
bors added S-waiting-on-bors 
…, r=jyn514,camelid,notriddle Fix clippy lints in librustdoc I ran clippy on librustdoc and simply fixed the lints. :) r? `@notriddle`
| @bors rollup=iffy (some of these changes may have perf implications) |
| ☀️ Test successful - checks-actions |
| Finished benchmarking commit (29b1248): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
| Consistent improvements of around 0.05% on instruction count for |
…r, r=jyn514 Remove unneeded into_iter As `@camelid` mentionned [here](rust-lang#89430 (comment)), the `into_iter` was unneeded. r? `@camelid`
…r, r=jyn514 Remove unneeded into_iter As ``@camelid`` mentionned [here](rust-lang#89430 (comment)), the `into_iter` was unneeded. r? ``@camelid``
7 participants
I ran clippy on librustdoc and simply fixed the lints. :)
r? @notriddle