Rollup of 6 pull requests #87698
Merged
Rollup of 6 pull requests #87698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When this gate is enabled, explicit generic arguments can be specified even if `impl Trait` is used in argument position. Generic arguments can only be specified for explicit generic parameters but not for the synthetic type parameters from `impl Trait`
…ackh726 Implement a `explicit_generic_args_with_impl_trait` feature gate Implements rust-lang#83701 When this gate is enabled, explicit generic arguments can be specified even if `impl Trait` is used in argument position. Generic arguments can only be specified for explicit generic parameters but not for the synthetic type parameters from `impl Trait` So code like this will be accepted: ```rust #![feature(explicit_generic_args_with_impl_trait)] fn foo<T: ?Sized>(_f: impl AsRef<T>) {} fn main() { foo::<str>("".to_string()); } ```
…oc, r=scottmcm Add documentation for the order of Option and Result This resolves issue rust-lang#87238.
Fix invalid suggestions for non-ASCII characters in byte constants Fixes rust-lang#87397.
…dtwco Tweak opaque type mismatch error
Inline some macros I factored out some macros that are not really necessary.
…, r=Mark-Simulacrum Add missing "allocated object" doc link to `<*mut T>::add` The portion of the documentation expecting the link was already there, but it was rendered as "[allocated object]". The added reference is just copied from the documentation for `<*const T>::add`.
Contributor Author
| @bors r+ rollup=never p=6 |
Collaborator
| 📌 Commit 7fc26e9 has been approved by |
bors added the S-waiting-on-bors Collaborator
Collaborator
| ☀️ Test successful - checks-actions |
This was referenced Aug 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
explicit_generic_args_with_impl_traitfeature gate #86176 (Implement aexplicit_generic_args_with_impl_traitfeature gate)<*mut T>::add#87690 (Add missing "allocated object" doc link to<*mut T>::add)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup