Skip to content

Prefer cmake3 to cmake when bootstrapping. #71262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Prefer cmake3 to cmake when bootstrapping. #71262

wants to merge 2 commits into from

Conversation

@alexreg
Copy link
Contributor

@alexreg alexreg commented Apr 17, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2020
@alexreg
Copy link
Contributor Author

alexreg commented Apr 18, 2020

(Tested on CentOS on GCC Compile Farm, incidentally.)
@joelpalmer joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2020
@bors
Copy link
Collaborator

bors commented Apr 30, 2020

☔ The latest upstream changes (presumably #71717) made this pull request unmergeable. Please resolve the merge conflicts.
@crlf0710
Copy link
Member

crlf0710 commented May 8, 2020

@alexreg Ping from triage, this needs a rebase.
@crlf0710 crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2020
@alexreg
Copy link
Contributor Author

alexreg commented May 8, 2020

@crlf0710 Happy to rebase right after a review... don't want to rebase just for it to sit around a while longer waiting for a review. :-)
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented May 8, 2020

@alexreg mark will review it this week, so better to rebase before that :)
@alexreg
Copy link
Contributor Author

alexreg commented May 8, 2020

@Dylan-DPC In that case, no prob. Shouldn't bitrot much (if at all) in a few days!
@joelpalmer joelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2020
@joelpalmer
Copy link

joelpalmer commented May 19, 2020

Ping from Triage: Any update @alexreg?
@Elinvynia Elinvynia added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2020
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented May 28, 2020

Going to close this out as inactive.
@nodakai nodakai mentioned this pull request May 30, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

8 participants

@alexreg @bors @crlf0710 @Dylan-DPC-zz @joelpalmer @Mark-Simulacrum @rust-highfive @Elinvynia