Update Cargo #50135
Merged
Update Cargo #50135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Some noteble changes: * regression fix: rust-lang/cargo#5390 * potentially breaking bug-fix: rust-lang/cargo#5389 * Cargo now caches the result of `rustc -vV`. It checks `rustc` binary mtime and rustup toolchain settings, so it should probably "just work" with rustbuild.
Contributor
| r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
|
rust-highfive added the S-waiting-on-review 
Member
I don't see anywhere in the diff related to this. If you mean rust-lang/cargo#5389 it is already included by #50056. |
Contributor Author
| @kennytm oh, indeed! Looks like 2 of 3 points are actually already here, updated the description! |
Member
| @bors r+ |
Collaborator
| 📌 Commit cb46d28 has been approved by |
bors added S-waiting-on-bors Collaborator
bors added a commit that referenced this pull request Apr 22, 2018
Update Cargo Some noteble changes: * ~~regression fix: rust-lang/cargo#5390 * ~~potentially breaking bug-fix: rust-lang/cargo#5389 * ~~Cargo now caches the result of `rustc -vV`. It checks `rustc` binary mtime and rustup toolchain settings, so it should probably "just work" with rustbuild.~~ potentially breaking bug-fix: rust-lang/cargo#5390
Collaborator
| ☀️ Test successful - status-appveyor, status-travis |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some noteble changes:
regression fix: Enable new behavior of--featurecargo#5390potentially breaking bug-fix: One hard cs problem cargo#5389Cargo now caches the result ofrustc -vV. It checksrustcbinarymtime and rustup toolchain settings, so it should probably "just work"
with rustbuild.
potentially breaking bug-fix: rust-lang/cargo#5390