(DO NOT MERGE) Mir inlining with spans #36689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Inlining needs to apply the substitutions from the callsite. Also implements TypeFoldable on IndexVec
The deaggregator will generate assignments that aren't allowed in const expressions. This also refactors `is_const_fn` into a method on `TyCtxt`.
Implements basic inlining for MIR functions. The cases it will inline for are conservative, any function that can unwind will not be inlined. Inlining is currently only done if `mir-opt-level` is set to 2. Does not handle debuginfo correctly at the moment.
Don't add an unwind edge if the call/drop/assert is in a cleanup block. This allows the pass to inline more functions correctly. Don't penalize intrinsics as harshly. They were previously treated the same as regular calls but now have the same cost as a statement. Run the before/after hooks for the pass. Since this is a MirMapPass, the hooks weren't run. Run copy propagation each time a function is inlined to remove any unecessary copies introduced during integration. This also makes copy propagation remove any nops it generated once it has finished. Run simplify cfg after inlining has finished for a SCC. This removes the need for a separate simplify cfg pass to be run.
| r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
| @bors: try |
bors added a commit that referenced this pull request Sep 24, 2016
(DO NOT MERGE) Mir inlining with spans @bors: try
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@bors: try