- Notifications
You must be signed in to change notification settings - Fork 13.9k
Revert "Auto merge of #146186 - dpaoliello:cc, r=jieyouxu" #148298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
| @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Revert "Auto merge of #146186 - dpaoliello:cc, r=jieyouxu"
This comment has been minimized.
This comment has been minimized.
| @rustbot reroll |
| r? me Looks good, feel free to @bors rollup=never delegate+
Also note this. |
This comment has been minimized.
This comment has been minimized.
| Finished benchmarking commit (6fe122f): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -3.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.2%, secondary -3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -1.1%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 475.565s -> 473.414s (-0.45%) |
This reverts #146186. This will mean regressing whichever
ccfixes were needed forIt's not clear which
ccchange causes the across-the-board perf regression, I suspect it's a change in how certain compiler flags are handed. But I can immediately tell this is a rabbit hole to investigate, so let's revert for now to return-to-baseline and alleviate time pressure.