Skip to content

Return Option from exact_div and inherit overflow checks #147784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return Option from exact_div and inherit overflow checks #147784

wants to merge 2 commits into from
+37 −31

Conversation

@nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Oct 16, 2025 •
edited by rustbot
Loading

According to #139911 (comment), exact_div should return Option::None if self % rhs != 0, panic if rhs == 0, and handle overflow conditionally (panic in debug, wrap in release).

#147771 should rename exact_div to div_exact.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

4 participants

@nxsaken @rustbot @rust-log-analyzer @scottmcm