Skip to content

rustdoc: don't ignore path distance for doc aliases #147701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

rustdoc: don't ignore path distance for doc aliases #147701

wants to merge 3 commits into from
+60 −2

Conversation

@lolbinarycat
Copy link
Contributor

@lolbinarycat lolbinarycat commented Oct 14, 2025 •
edited
Loading

Ran into a bit of an issue due to the overloading of space (it needs to be a metachar for most searches, but not for doc aliases that have space in them). Not sure if I need to also need to account for other whitespace chars.

screenshot

fixes #146214

r? @GuillaumeGomez
@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat
@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
yotamofek
yotamofek reviewed Oct 14, 2025
View reviewed changes
src/librustdoc/html/static/js/search.js
*/
const handleAlias = async(name, alias, dist, index) => {
const item = nonnull(await this.getRow(alias, false));
// space both is an alias for ::,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant "a space is both an alias...", but not sure
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe either is grammatically correct.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the rustdoc-search-alias-fix branch from 853c99a to 0707281 Compare October 15, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

5 participants

@lolbinarycat @rustbot @rust-log-analyzer @yotamofek @GuillaumeGomez