More robust stack protector testing #147115
Conversation
…tics-effect-llvm.rs
rustbot added S-waiting-on-review 
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ics-effect-llvm.rs -> tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs new file: tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-windows-32bit-2.rs new file: tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-windows-64bit-2.rs
…tics-effect-windows-64bit-2.rs
…tics-effect-windows-32bit-2.rs modified: tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-windows-64bit-2.rs
This comment has been minimized.
This comment has been minimized.
rustbot added has-merge-commits 
This comment has been minimized.
This comment has been minimized.
rustbot removed S-waiting-on-author This comment has been minimized.
This comment has been minimized.
rustbot added has-merge-commits …tics-effect-windows-64bit-2.rs
|
rustbot removed has-merge-commits 
| I'm looking this and gonna give some comments, expecting in the next week |
There was a problem hiding this comment.
Please split the PR into multiple commits according to the logical organization of the test, which makes it easier for others to review.
And if your tests are coming from llvm tests, could you write something like a sheet to explain if these result in rustc are all expected?
| fn dummy(_: ...) -> i32; | ||
| | ||
| static STR: [u8; 1]; | ||
| } |
There was a problem hiding this comment.
Could you add some comments about why we need these extern functions?
| // #[repr(C)] | ||
| // struct A { | ||
| // data: [u8; 2], | ||
| // } |
There was a problem hiding this comment.
Why are these code left here
| } | ||
| | ||
| // Note: test2 | ||
| // struct -> flat aggregate -> array |
There was a problem hiding this comment.
These codes too, please add some comments to explain why keep these codes
| | ||
| // CHECK-LABEL: test3{{:|\[}} | ||
| #[no_mangle] | ||
| pub fn test3(a: *const u8) { |
There was a problem hiding this comment.
Can you make these test function names more meaningful? Or add some comments to explain
6 participants
I've added some tests related to the stack protector. These tests were originally in the LLVM stack protector test project.
These tests were written for the "Stabilize stack-protector" proposal, and therefore removed the "stack-protector=basic" test option, as this stack protector was considered ineffective in Rust.
For the proposal, see: #146369
For the discussion, see zulip: https://rust-lang.zulipchat.com/#narrow/channel/233931-t-compiler.2Fmajor-changes/topic/Proposal.20for.20Adapt.20Stack.20Protector.20for.20Ru.E2.80.A6.20compiler-team.23841
r? @wesleywiser (feel free to reassign)
cc @nikic, @rcvalle, @davidtwco, @arielb1, @Darksonn, @Noratrieb, @SparrowLii