Skip to content

Uplifts and extends clippy::needless-maybe-sized into rustc #145924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Uplifts and extends clippy::needless-maybe-sized into rustc #145924

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8869a8c
Uplifts needless-maybe-sized lint from clippy
CrooseGit Jul 29, 2025
06b467a
Renames lint to redundant-sizedness-bound
CrooseGit Aug 18, 2025
ae6c9cc
Extends tests
CrooseGit Aug 19, 2025
8a05d4d
Extends lint
CrooseGit Aug 19, 2025
d846194
Deprecates needless-maybe-sized in clippy
CrooseGit Aug 26, 2025
66f91da
Applies changes suggested by reviewers
CrooseGit Sep 26, 2025
f9cf338
Responding to reviewer feedback
CrooseGit Oct 13, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Responding to reviewer feedback
  • Loading branch information
@CrooseGit
CrooseGit committed Oct 13, 2025
commit f9cf338ae48eb0c0ad7c9900b5b8d0ecc286eae5
2 changes: 2 additions & 0 deletions compiler/rustc_lint/src/redundant_sizedness_bounds.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ fn check_redundant_sizedness_bounds(
let redundant_sized_params: DefIdMap<_> = type_param_bounds(generics)
.filter(|bound| {
bound.trait_bound.trait_ref.trait_def_id() == Some(redundant_bound)
// Here we wish to compare the variant of the enum `BoundPolarity` whilst
// disregarding the contents of the variant.
&& std::mem::discriminant(&bound.trait_bound.modifiers.polarity)
== std::mem::discriminant(&redundant_bound_polarity)
})
Expand Down
Loading