- Notifications
You must be signed in to change notification settings - Fork 14k
Rustc dev guide subtree update #135829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rustc dev guide subtree update #135829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Save linkcheck cache always
This will cause the CI build to be marked successful even if the build failed. Instead, use `if: '!cancelled()'` to always save the cache (except when the job is cancelled), even if the linkcheck failed. See https://stackoverflow.com/a/58859404 for more.
ci: Remove incorrect use of `continue-on-error`
This documents how to determine which settings are used in CI, since I see this question come up regularly. We currently don't have a great way to answer the question, but at least there is something.
* Rename `StringReader -> Lexer` * Remove deleted `Query` struct * Update some internal links
incorrect wording
…nce-invariance
Co-authored-by: Boxy <rust@boxyuwu.dev>
rustc pull
Send a message to Zulip when a sync finishes
Collaborator
| The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
Member Author
| @bors rollup=never |
jieyouxu approved these changes Jan 21, 2025
Member
jieyouxu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Member
| @bors r+ |
Collaborator
Member
| @bors rollup (discussed on zulip that this can be rolled up) |
joboet added a commit to joboet/rust that referenced this pull request Jan 24, 2025
Rustc dev guide subtree update r? `@ghost`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
Rollup of 6 pull requests Successful merges: - rust-lang#135728 (document order of items in iterator from drain) - rust-lang#135829 (Rustc dev guide subtree update) - rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly) - rust-lang#135977 (Fix `FormattingOptions` instantiation with `Default`) - rust-lang#135983 (Doc difference between extend and extend_from_slice) - rust-lang#135985 (Rename test to `unresolvable-upvar-issue-87987.rs` and add some notes) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#135415 (Add `File already exists` error doc to `hard_link` function) - rust-lang#135581 (Separate Builder methods from tcx) - rust-lang#135728 (document order of items in iterator from drain) - rust-lang#135749 (Do not assume const params are printed after type params) - rust-lang#135829 (Rustc dev guide subtree update) - rust-lang#135938 (Add memory layout documentation to generic NonZero<T>) - rust-lang#135949 (Use short type string in E0308 secondary span label) - rust-lang#135976 (Don't drop types with no drop glue when building drops for tailcalls) - rust-lang#135998 ([rustdoc] Fix indent of trait items on mobile) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 25, 2025
Rollup merge of rust-lang#135829 - Kobzol:rustc-push, r=jieyouxu Rustc dev guide subtree update r? ``@ghost``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
r? @ghost