- Notifications
You must be signed in to change notification settings - Fork 13.9k
has_typeck_results doesnt need to be a query #123992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
| r=me whether or not you want to check perf |
| extremely doubt that this will be negative, but yeah, that's a good thing to check @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…s, r=<try> `has_typeck_results` doesnt need to be a query self-explanatory
| ☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
| Finished benchmarking commit (3b171da): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 678.486s -> 678.725s (0.04%) |
| @bors r=jackh726 |
…s, r=jackh726 `has_typeck_results` doesnt need to be a query self-explanatory
| 💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
| huh??? |
ac77e35 to 3c4e2ae Compare | ah, rebase @bors r=jackh726 |
This comment has been minimized.
This comment has been minimized.
| @bors r- |
3c4e2ae to 6abf1aa Compare | whoops forgot to reapprove after formatting @bors r=jackh726 |
…s, r=jackh726 `has_typeck_results` doesnt need to be a query self-explanatory
| 💔 Test failed - checks-actions |
| wtf ci @bors retry |
| ☀️ Test successful - checks-actions |
| Finished benchmarking commit (a77f76e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.396s -> 675.73s (0.20%) |
…s, r=jackh726 `has_typeck_results` doesnt need to be a query self-explanatory
self-explanatory