[perf] alternative approach to #117703 #118136
Conversation
| @bors try @rust-timer queue |
rustbot added A-query-system 
| Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
rustbot added the S-waiting-on-perf 
[perf] alternative approach to rust-lang#117703 cc rust-lang#117703 r? `@compiler-errors`
This comment has been minimized.
This comment has been minimized.
| Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
| @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[perf] alternative approach to rust-lang#117703 cc rust-lang#117703 r? `@compiler-errors`
| ☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
compiler-errors removed the S-waiting-on-review 
| let mut cycle: VecDeque<_> = cycle_error.cycle.iter().collect(); | ||
| | ||
| let guar = 'search: { | ||
| for _ in 0..cycle.len() { |
There was a problem hiding this comment.
What's the purpose of this for loop if you're just using 0 below?
| } | ||
| break 'search diag.emit(); | ||
| } else { | ||
| cycle.rotate_left(1); |
There was a problem hiding this comment.
Oh lol, interesting approach.
| Finished benchmarking commit (6c239c9): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.833s -> 675.717s (0.28%) |
rustbot added perf-regression 
6 participants
cc #117703
r? @compiler-errors