Map trait improvements #10547
Closed
Map trait improvements #10547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Instead of associating a redundant key with each value, so find_or_insert_with can keep a reference to it, just store the one that was just inserted.
Contributor
| This... what? @davidhalperin did you push to this PR's branch after it got merged? |
Contributor
| @cmr: GitHub associates comments with commits, so it's showing comments from another pull request - it looks like changes were merged into this branch rather than it being rebased onto master |
Contributor Author
| Sorry, I'm new to git. Fixed, I think, but let me know if there's still an issue. |
Member
| Closing due to a lack of activity. I also believe that the |
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 6, 2023
…zation-nursery, r=flip1995 Move unnecessary_struct_initialization to nursery changelog: none, assuming it makes into the same release as rust-lang#10489 Mostly because of rust-lang#10547 but there is also rust-lang#10548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add methods
find_or_insert,find_or_insert_with,insert_or_update_withandreserve_at_leastto theMutableMaptrait.Closes #5568.
The unsafe way of implementing
find_or_insert_withonTreeMapmentioned in the issue discussion doesn't work after all. The way done here isn't great but it works at least. Someone can come up with a better implementation in the future but I don't think that should hold the rest of this up.