Skip to content

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 2, 2022

Fixes #101324
r? @ghost
now finally with the FFI support we had to bail out last time :D

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2022

The Miri submodule was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

RalfJung commented Sep 2, 2022

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Sep 2, 2022

📌 Commit fe7e207 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 2, 2022
@bors
Copy link
Collaborator

bors commented Sep 2, 2022

⌛ Testing commit fe7e207 with merge b88e510...

@bors
Copy link
Collaborator

bors commented Sep 2, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing b88e510 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2022
@bors bors merged commit b88e510 into rust-lang:master Sep 2, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 2, 2022
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #101331!

Tested on commit b88e510.
Direct link to PR: #101331

🎉 miri on linux: test-fail → test-pass (cc @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 2, 2022
Tested on commit rust-lang/rust@b88e510. Direct link to PR: <rust-lang/rust#101331> 🎉 miri on linux: test-fail → test-pass (cc @oli-obk @RalfJung).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b88e510): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.3% [2.6%, 6.2%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.4% [-8.8%, -3.2%] 6
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

@RalfJung RalfJung deleted the miri branch September 14, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

6 participants