Skip to content

Don't cancel try-perf branch if 'outdated' #100033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

Don't cancel try-perf branch if 'outdated' #100033

merged 1 commit into from
Aug 2, 2022
+4 −4

Conversation

@rylev
Copy link
Member

@rylev rylev commented Aug 1, 2022

try-perf just like the try branch should always run all jobs to completion. This allows us to use the branch like a queue.

r? @Mark-Simulacrum
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Aug 1, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2022
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Aug 1, 2022

@bors r+ rollup p=1

To clarify, the builds aren't queued, they run in parallel, but we are able to just dump a set onto the branch rather than queuing elsewhere. I guess you can pop from a queue in parallel too :)
@bors
Copy link
Collaborator

bors commented Aug 1, 2022

📌 Commit 5a3cc95492c7412f48e1bf5aa211a1dd556ed76e has been approved by Mark-Simulacrum

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2022
@bors
Copy link
Collaborator

bors commented Aug 1, 2022

⌛ Testing commit 5a3cc95492c7412f48e1bf5aa211a1dd556ed76e with merge dfadf2593af5848e11b063a83a6518ec3737ddbd...
@bors
Copy link
Collaborator

bors commented Aug 1, 2022

💔 Test failed - checks-actions
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 1, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Aug 1, 2022

@bors r+ rollup p=1
@bors
Copy link
Collaborator

bors commented Aug 1, 2022

📌 Commit debb75a has been approved by Mark-Simulacrum

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2022
@bors
Copy link
Collaborator

bors commented Aug 2, 2022

⌛ Testing commit debb75a with merge 9d5cd21...
@bors
Copy link
Collaborator

bors commented Aug 2, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 9d5cd21 to master...
@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2022
@bors bors merged commit 9d5cd21 into rust-lang:master Aug 2, 2022
@rustbot rustbot added this to the 1.64.0 milestone Aug 2, 2022
@rust-timer
Copy link
Collaborator

rust-timer commented Aug 2, 2022

Finished benchmarking commit (9d5cd21): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -4.9% -4.9% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -4.9% -4.9% 1

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 4.2% 5.9% 11
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 4.2% 5.9% 11

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2
@rylev rylev deleted the no-cancel-try-perf branch August 2, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

7 participants

@rylev @Mark-Simulacrum @bors @rust-log-analyzer @rust-timer @rust-highfive @rustbot