Skip to content

Conversation

@JHWelch
Copy link
Contributor

@JHWelch JHWelch commented Sep 12, 2023

This is a minor reorganization in the diff2html-tests.ts.

While working on a new feature I noticed that the describe('getJsonFromDiff', () => { /* ... */ } block was wrapping the entire file, and seemed to have what I assume is the old name for patch.

I renamed that section and added a new describe block for the html section.

Decided to handle this separately from the other PR.

Copy link
Owner

@rtfpessoa rtfpessoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for the PR

@rtfpessoa rtfpessoa merged commit 8102d3c into rtfpessoa:master Sep 19, 2023
@JHWelch JHWelch deleted the organize-diff2html-tests branch September 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants