Skip to content

Conversation

rsokl
Copy link
Owner

@rsokl rsokl commented Feb 11, 2018

Improving content based on feedback specified in issue #29 by @AFederici

@davidmascharka
Copy link
Collaborator

My comments reading the modifications:

SiteFormatting.ipynb

👍

Basic_Objects.ipynb

L410: Change "Assume x and n are both types numbers" to "Assuming x and n are both types of numbers"

ConditionalStatements.ipynb

I like that addition.

DataStructures.ipynb

👍

DataStructures_II_Dictionaries.ipynb

L191: "when using a floating point" should be "when using floating-point" <-- remove 'a' and add a hyphen.
L191: maybe too picky but "two floating points" isn't really correct since the 'float' refers to the decimal point 'floating' around any digit, as opposed to fixed-point arithmetic. You should technically say "two floating-point numbers" but "two floats" would be colloquially correct too.

L202: hyphenate floating-point

Functions.ipynb

L372: hahaha I really enjoy the original. Ryan sounds like a doomsday prophet: "It cannot be forseen!"

L446: should be "this dictionary is then assigned to the variable args" rather than args being assigned to the dictionary.

L459: maybe say "No positional arguments may come after a ** entry" instead of "no arguments" since by definition keyword arguments can come.

Generators_and_Comprehensions.ipynb

I'm assuming that's good.

SequenceTypes.ipynb

👍

intro.rsp

👍

@rsokl
Copy link
Owner Author

rsokl commented Feb 13, 2018

I think your concern with "two floating points" is well-founded. Students don't have a chance of understanding what "the floating point" is, if you use it improperly.

@rsokl rsokl merged commit 60e5d14 into master Feb 13, 2018
@rsokl rsokl deleted the AFed_edits branch February 13, 2018 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants