Proofing module2: finalizing my edits #17
Conversation
| actually, the python syntax highlighting does work in the callout boxes, when rendered in html by nbsphinx. In general, just leave those boxes alone (unless you see a typo), since it is one of the few things that doesn't render in the notebook as it does on the site. |
| Ah, that's good to know. Give me a few minutes and I'll revert that portion. |
| "There are reading-comprehension exercises included throughout the text. These are meant to help you put your reading to practice. Solutions for the exercises are included at the bottom of this page.\n", | ||
| "</div>\n", | ||
| "\n", | ||
| "The following objects are all example of sequences:\n", |
There was a problem hiding this comment.
why did you delete this ? (L16-L34)
There was a problem hiding this comment.
@davidmascharka let me know if it is easier for me to restore this section, and I can do it
There was a problem hiding this comment.
@rsokl there was some weird merge conflict because I didn't realize my worktree wasn't up-to-date. I can just wipe out this branch and start over from clean master. This would fix the callout I broke too. Let me know
| See #18 |
2 participants
Itertools.ipynb
L8: memory-efficient is a single descriptor
L10: ad a comma
L79: version
Scope
L160: 🙄 apparently I saved the file without modifying anything, which updated the version...consistency update!
SequenceTypes.ipynb
L16: built into
L26: round-brackets? Really? They're parentheses. I have never heard anybody use the term "round bracket" in my life.
L49: remove the
pythonhint at syntax highlighting because it doesn't work in a callout box and just unnecessarily adds the word 'python' which is confusingL188/189: add a period
L198/199: first entry in a sequence, not into a sequence
L215/216: proper capitalization on NumPy for consistency
L258/259: the number 0 isn't even in
x...L274/275: I would say we index into a sequence; we don't index it. That sounds like we're cataloging the sequence.
L285-287/286-288: colons instead of commas since we're defining things for the first two; remove the hyphen on the third
L319/320: make use the default sounds real weird. Use the default is fine.
L333/334: start and stop values will change, not changed
L348/349: start, stop, and step; we don't have multiple stop values
L389/390-391: we should define
xif we're going to use itL408/410: source of errors
L430/432: You can't get a list from a tuple by slicing it
L453/455: add commas to those tuples
L553/555: version
Variables_and_Assignment.ipynb
L17: caveman Ryan "want write code" -- everybody else wants to write code
L19: assign objects to variables
L21-22: same as L19
L24: assign objects to variables
L133: remove awkward comma
L136: remove the word 'to' because we assign y the integer 2 or we assign 2 to y
L145: same as L136
L163: properly stylize NumPy
L209: version