Edits for Module 2 #14
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I'm going to open this so I don't have to write all the changes I make to the entire section at once. I'll push changes to each subsection and edit this post, which will contain all the changes. When I've finished this I'll assign you to it.
Basic_Objects.ipynb
L16: we assign things to variables; we don't assign variables to things
L18: add missing 'the'
L18: built-in to -> built into
L18: add missing 'a'
L49: spelling fix
L53: Addition -> Sum since everything else is written that way
L117: ipython -> IPython
L183:
,
to;
L234:
-0.2e10
isn't actually standard scientific notation, which should be-2e09
, so I changed the0
to a4
.L236: remove commas because 'that possesses many digits' isn't an independent clause
L299: 'warranted at all' -> 'warranted' because the former makes it sound like error analysis is rarely warranted
L301: add missing 'it' for 'it is very important'
L311: Make "LOL electrical engineers suck!!" less offensive
L376: add a colon
L436: remove 'an' becaues 'write an a comparison' is bad
L456: 'as a operation' -> 'as an operation'
L473: specify that
None
if often used as a placeholder so it doesn't sound like it's only a placeholderL541: "common interface that Python for all of its types" -> "common interface that Python has for all"
L633: "allows use to store" -> "allows us to store"
L701: "after its been constructing" -> "after it has been constructed"
L766: we're assigning a list to the variable
k
, not the other way around776: we assign things to variables, not variables to things
L781:
True
,False
->True
andFalse
L905-906: add another possible solution because why perform a
not
when you don't have toL1010: versions
ConditionalStatements.ipynb
L19: add the word "values" or it sounds like the boolean represents (True and False)
L47: there's only one assignment operator
L50: we assign values to variables, not the other way around
L101: we ascribe values to things, not things to values
L139: boolean values, not boolean-values
L161: "their general template" -> "the general template" (otherwise whose general template is it?)
L221-249: Add examples of
if
withelif
and noelse
and ofif
withelse
and noelif
to be clear these are fine.L373: versions...
Note: I would totally use the ternary operator in an arithmetic expression. Also in string concatentation. It's a great operator.
DataStructures.ipynb
L11: 'set-algerbra' -> 'set-algebraic'
L13: 'core-utilities' -> 'core utilities'
L159: version
DataStructures_II_Dictionaries.ipynb
L10:
,
to;
L14: add a space for consistency
L19: 'is-in' -> 'is in'
L89: hasn't be -> hasn't been
L149: 'contents are the dictated' -> 'contents are dictated'
L268-269: complexity -> time complexity, since space complexity is also a valid complexity.
L275: add a space
L279: kay-value pairs
L294:
,
to;
L313: less memory than before
L365: version
DataStructures_III_Sets_and_More.ipynb
L12: an O(1) -> a O(1) -- this could go either way, but it's pronounced big-oh, so I think it should be a big-O, not an big-O.
L12: add the word 'if' to make it a statement, not a question.
L59:
,
to;
L103:
,
to;
L131: 'some of utility of' -> 'some of the utilities of'
L141: 'by-name' -> 'by name'
L149: 'holds space-time coordinate' -> 'holds a space-time coordinate'
L170: remove the phrase "to initialize" because it's not needed and "used to initialize as a default" doesn't make sense.
L193: was that test English? 😛
L198: apparently it was
L299: versioning
ForLoops.ipynb
L87-98: You already said exercises would be included
L111/99: for -> whlile
L115/103: add the word 'and' to clarify
L123/111: move the comment for readability, or else you explain a thing before it happens
L145/132: it's -> its
L169/156: statements are to be used -> statements can be used -- you're not forced to use them
L313/300: version
Functions.ipynb
L25:
vowel_count
isn't defined --num_vowels
L29:
vowel
is pluralL163: vowels, plural
L181: remove unnecessary 'of'
L195-198: move the import function to after the early return to save even more time
L202: change
1.
to1.0
because hanging decimals are disgustingL231: the finally? the following
L250: remove silly hyphens
L276:283: Add an example showing that you have to specify all your positional arguments before any named arguments
L284/292: remove extra 'to'
L295/303: move 'only' to flow better
L338/346: neither, nor -- not neither, or
L421/429: I seriously hope 'Hello' has 2 vowels according to your function, not 1
L560/568: version
Generators_and_Comprehensions.ipynb
L17: allows use -> allows us
L71: number -> numbers
L248: content -> contents
L336: remove extra word 'at'
L428: remove unnecessary comma
L442: sentence break
L621: version
Introduction.ipynb
L9: code is executed, not are executed
L42: instructs -> instruct
L65: versions
Iterables.ipynb
L17: add the word 'and'
L79: assign values to variables
L82: same as 79
L93: contents get assigned to variables
L101: "greatly facilitates the readability" sounds weird to me, so I'm proposing "improves"
L122:
,
to;
L166: you didn't define
none_indices
L178/179: add 'the'
L284/285: Jupyter version