Skip to content

Conversation

@idkjs
Copy link

@idkjs idkjs commented Dec 26, 2020

Binding target name needs to be updated. Its now

[@bs.module "@react-native-picker/picker"] 

I have also update the Item module label property which should be optional per typing

(JSX attribute) PickerItemProps.label?: string 

Updated is:

module Item = { @react.component @bs.module("@react-native-picker/picker") @bs.scope("PickerIOS") external make: ( ~value: 'a=?, ~label: string=?, ~color: ReactNative.Color.t=?, ~testID: string=?, ) => React.element = "Item" } 
@idkjs idkjs requested review from MoOx and sgny December 26, 2020 18:30
@MoOx
Copy link
Member

MoOx commented Jan 8, 2021

To avoid a breaking change for this package, I would prefer to have the name updated in next minor release (not as a patch release). Can you make a PR with just the label change for now please?

@idkjs
Copy link
Author

idkjs commented Jan 9, 2021

Done

Copy link
Member

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

**/lib/bs
**/lib/ocaml
**/.merlin
_esy/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_esy/
@MoOx
Copy link
Member

MoOx commented Feb 19, 2021

Hum after reviewing, the name is still updated here... Going to handle this.

@MoOx MoOx closed this Feb 19, 2021
@MoOx MoOx deleted the update-binding-package-name branch February 19, 2021 13:47
@idkjs
Copy link
Author

idkjs commented Feb 20, 2021

Ok. Makes sense. It optional sometimes. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants