Upgrade Rust to 1.91.0 #8007
Merged
Upgrade Rust to 1.91.0 #8007
+81 −66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
nojaf reviewed Nov 8, 2025
Member
nojaf left a comment
nojaf left a comment There was a problem hiding this comment.
Can you add a pointer to https://github.com/rescript-lang/rescript/blob/master/CONTRIBUTING.md that users should install the version mentioned in our Cargo.toml?
Even though that might be obvious to existing Rust users, I prefer to spell these things out for newcomers.
Member Author
| BTW there is now also https://github.com/actions-rust-lang/setup-rust-toolchain, but I couldn't get it to work. |
Member
| Yes, it does seem now that we use a rather obscure action to install Rust. |
# Conflicts: # CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.