Adjust to bs-* deprecations #7692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 3ce8b04.
| Struggling to figure out how to update the rewatch snapshots locally.. |
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
cknitt reviewed Jul 22, 2025
I wrote why there's no changelog in the PR description, did you see that? |
Oops, no, sorry! |
cknitt approved these changes Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adjusts more stuff to the
bs-*deprecations.I pretty much simply trust that the build system will error if both are defined, so I don't care too much about that type of logic for this.
I couldn't add proper tests for this in the analysis, because this requires rewatch and I can't get the analysis tests to build with rewatch right now.
I don't think this needs a changelog since #7658 already has one.