React ppx: enable spread for dom elements children #4631
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@rickyvetter The error raised when using spread with DOM elements prevents sharing components code that can be compiled with both tyxml and reason-react.
This error was useful when migrating from JSX2, but I hope ReasonReact users are not running into it these days as the spread operator has been mostly removed from JSX3 documentation, so I hope the change is ok.
This is an example of element that compiles fine with tyxml and succeeds after these change with ReasonReact as well: