Skip to content

[playground] fix jsoo_refmt_main, remove load_modules as not necessary #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2020
Merged

[playground] fix jsoo_refmt_main, remove load_modules as not necessary #4408

merged 1 commit into from
May 24, 2020

Conversation

@jchavarri
Copy link
Contributor

@jchavarri jchavarri commented May 24, 2020 •
edited
Loading

Adds "/static" to directory in jsoo_refmt_main (like jsoo_main).

Removes load_modules as it's not needed anymore. Using js_of_ocaml.bc build-fs creates a JS file that will add a file to jsoo pseudo file system directly when loaded, removing the need for providing an API hook on the compiler.

cc @ryyppy
@bobzhang bobzhang merged commit 2763942 into rescript-lang:master May 24, 2020
@jchavarri jchavarri deleted the jsoo-refmt-load-static branch May 25, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jchavarri @bobzhang