Indent deprecation warning's userland message #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Before it was like: ``` deprecated: Belt.List.filterWithIndex This function will soon be deprecated. Please, use `List.keepWithIndex` instead. ``` Now it's: ``` deprecated: Belt.List.filterWithIndex This function will soon be deprecated. Please, use `List.keepWithIndex` instead. ``` This helps with the visual but also the parsing of the messages. Without our super errors system, this'll now look like: ``` deprecated: Belt.List.filterWithIndex This function will soon be deprecated. Please, use `List.keepWithIndex` instead. ``` Which is still tasteful
| Fixes rescript-lang/rescript-vscode#45 |
| cherry-picked |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Before it was like:
Now it's:
This helps with the visual but also the parsing of the messages.
Without our super errors system, this'll now look like:
Which is still tasteful