Reference the true interface file (.resi, rei) when an implementation fails to implement its contract #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Note that `Some ()` goes to constant branch For constant branch, we pretty much know it is. undefined or not while `Some (x : unit)` goes to type based analysis For type based, if it is predefined unit, done, otherwise need check its constructor description
turn Fld_na to Fld_na of string for debugging
- transl_extension_path will be a temporary thing, it is a string in BS - in native, for non-const, it compares (Fld 0) with `transl_extension_path`, for const, it use itself to compare against `transl_extension_path` - for bs, in both cases, it calls `extension_slot_eq exn transl_extension_path`
…e sets per backend
… fails to implement its contract
| @mweichert thanks for the suggestions, we will think about it. Note it is a bit more complicated since the source are in various syntaxes |
bobzhang force-pushed the 4.06.1+BS branch 3 times, most recently from 487c226 to 0090035 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ReScript developers don't understand (or shouldn't need to understand) why a .cmi file is referenced, especially when it doesn't exist in the path referenced in the error message.
Before:
After: