Skip to content

Conversation

@ulrikstrid
Copy link

This allows us to skip submodule checkout in git. I'm opening a companion PR on bucklescript/bucklescript as well.

cristianoc added a commit to rescript-lang/rescript that referenced this pull request Nov 3, 2019
@bobzhang bobzhang requested a review from cristianoc November 4, 2019 01:56
@bobzhang
Copy link
Member

bobzhang commented Nov 4, 2019

LGTM, @cristianoc can you confirm it works?

@cristianoc
Copy link

@bobzhang I have abandoned this for now:
rescript-lang/rescript#3910

@ulrikstrid
Copy link
Author

This works to build under Windows with esy now. I had to remove flexdll and use a special esy version instead, does this break the normal flow, if it does I can probably get the script to remove the current flexdll instead.

I can add the Azure Pipelines that are normally in esy-ocaml to make sure that this works @bobzhang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants