explicit lazy val handling #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15839 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15852 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
This reverts commit 4.02@15753 (4892549 ). The feature is not ready yet, it breaks compilation of programs that merely link .c files inside a standard executable. See PR#6475 for further discussion. git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15863 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15864 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15865 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
…rr_formatter git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15867 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15870 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15871 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15872 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15873 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15879 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15882 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
(Jérémie Dimino, request by Peter Zotov) git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15891 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
…#' in trailing symbols, although the operator is then rejected by the type-checker). (Cherry-picked from trunk, rev 15892.) git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15893 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15894 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15895 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
…s; attributes come after constructor/field declarations. git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15896 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
…he callback in that case. git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15898 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
…files" This break oasis-using packages because -thread, as explained in PR#6809. This reverts commit 429a397. git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15903 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15916 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15926 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15927 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15928 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15929 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15930 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15931 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15932 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15933 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15934 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
git-svn-id: http://caml.inria.fr/svn/ocaml/version/4.02@15935 f963ae5c-01c2-4b8c-9fe0-0dff7051ff02
TODO: cherry-pick on 4.06
- save_signature_with_imports is used in -pack - save_signature used in Typemod.type_implementation & and `after_parsing_sig` - output_cmi is used in saving cmt file TODO: design cmi format to make this operation more efficient
This exposes the first `report_error` binding from the vendored `typecore.ml` (the binding is shadowed afterward). This allows us to avoid copy pasting the whole error pattern matching logic, which differs enough between compiler versions to be annoying to cppo. I have a similar `typecore.ml` patch for the 4.06 compiler
[Super errors] Simplify super_typecore logic
I'm not sure why this is here, but the changes already got in, in 164758af4802ca6624dc3648d46b32f559cdfe69. And I think this commit didn't get applied in an idempotent way? Now we ended up with two `#if` lol
9c4e02ed8021c796db307681a32f87a785d6f0b5 is a revert of 164758af4802ca6624dc3648d46b32f559cdfe69. But I noticed just now that typecore.mli correctly added the #if only once (contrary to typecore.ml). So I'm adding the #if back into the interface file.
* [Super errors] Expose previously shadowed `report_error` Used by super_typemod.ml * [Super errors] Clean up super_typemod Defer work to the newly exposed `Typemod.super_report_error_no_wrap_printing_env`
- when making blocks, adding explicit block tag for each kind - not inline lazy destruction, it does not make sense under JS setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.