Reload all dependent JS when files change #98
Conversation
Use a custom watcher/reloader middleware to find all the dependent files of component_filenames and watch them for changes. The reloader sits outside of the Rails stack, but makes use of ActiveSupport::FileUpdateChecker. This has a few benefits: 1. Non-jsx files can easily be watched. For example, changes to components.js and other helper files are detected. 2. Newly required files can be detected and added to the list of watched files for future updates. 3. We don’t force Rails to reload its own Ruby classes when only .js or .jsx files have changed. One potentially controversial change, which didn’t seem to provide much benefit before: - Moved the concatenated source files for components.js and react.js out of the app config. They are now encapsulated in the after_initialize block.
| Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
| Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| This is great! 👍 |
lib/react/rails/railtie.rb Outdated
There was a problem hiding this comment.
How about component_source_files or component_sources, since we are catching multiple files here?
There was a problem hiding this comment.
We are catching multiple files, but it ends up as a single large source block. So I have renamed to combined_components_source to better document its purpose.
We only ever expect to call this internally, so the extra check is not very useful.
Make it clearer that it is the result of concatenating all the component source files listed in the config.
5 participants
Use a custom watcher/reloader middleware to find all the dependent
files of component_filenames and watch them for changes.
The reloader sits outside of the Rails stack, but makes use of
ActiveSupport::FileUpdateChecker.
This has a few benefits:
components.js and other helper files are detected.
watched files for future updates.
or .jsx files have changed.
One potentially controversial change, which didn’t seem to provide
much benefit before:
out of the app config. They are now encapsulated in the
after_initialize block.