Skip to content

Conversation

@olance
Copy link
Contributor

@olance olance commented Aug 30, 2014

Not much, but the info is missing and could avoid errors when trying to run tests for the first time ^^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: PhantomJS, and probably worth making that a link.

@jtmalinowski
Copy link
Collaborator

How about we link to https://github.com/teampoltergeist/poltergeist with a hint to head there?

@jtmalinowski
Copy link
Collaborator

@olance my bad it took me this much time to respond, just let me know if you are still going to finish this PR

@olance
Copy link
Contributor Author

olance commented Oct 12, 2014

@JakubMal no worries, I do not have much free time on hand either ^^
So yes, I'd like to finish this PR, just let me know: would you go with an example test too? Do I need to rebase the PR?

@zpao
Copy link
Member

zpao commented Oct 14, 2014

Just address the comments but ignore the example test part. You can do it in a new commit or amend your current commit and rebase, your call.

@olance
Copy link
Contributor Author

olance commented Oct 14, 2014

👍

@rmosolgo
Copy link
Member

rmosolgo commented Oct 4, 2016

Sorry for leaving so long, for a while there's been a short instruction on how to run the tests in the Readme:

image

Feel free to rebase & open another PR if you think that documentation should be extended!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants