Skip to content

add auto hot reload support #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EdmondChuiHW wants to merge 21 commits into from
Closed

add auto hot reload support #1065

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ee3557f
add renderComponent extension point
edmond-c Apr 25, 2020
7cb3d15
doc + default
edmond-c Apr 25, 2020
acdee60
mirror getConstructor structure
edmond-c Apr 25, 2020
6543967
add missing variable
edmond-c Apr 25, 2020
bfe0549
update readme
edmond-c Apr 25, 2020
ad27aee
rollback hot reload specfic diffs
edmond-c Apr 25, 2020
304fa1e
Revert "rollback hot reload specfic diffs"
edmond-c Apr 25, 2020
210f835
add back fn signature
edmond-c Apr 25, 2020
6537709
Update README.md
EdmondChuiHW Apr 26, 2020
5c4cf92
Update README.md
EdmondChuiHW Apr 26, 2020
4a71138
Update index.js
EdmondChuiHW Apr 26, 2020
bff3b07
Update withHotReload.js
EdmondChuiHW Apr 26, 2020
dbc43fd
Update withHotReload.js
EdmondChuiHW Apr 26, 2020
01eb0f0
reload multiple elements of same component
EdmondChuiHW Apr 29, 2020
1741e73
render correct props
EdmondChuiHW Apr 29, 2020
02f7217
refactor re-render
EdmondChuiHW Apr 29, 2020
087211e
Update README.md
EdmondChuiHW Apr 29, 2020
6963eaf
only re-render mounted components
EdmondChuiHW Apr 29, 2020
fffc5e8
Update index.js
EdmondChuiHW Apr 29, 2020
a53b327
Merge pull request #1 from EdmondChuiHW/extend-renderComponent
EdmondChuiHW Apr 29, 2020
5d06769
support re-rendering portal elements
EdmondChuiHW Apr 29, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reload multiple elements of same component
  • Loading branch information
@EdmondChuiHW
EdmondChuiHW authored Apr 29, 2020
commit 01eb0f05857c440e64dc4d55eddd791d11d2c1cf
15 changes: 14 additions & 1 deletion react_ujs/src/renderComponent/withHotReload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ module.exports = function(webpackRequireContext) {
var FreshConstructor = ReactRailsUJS.getConstructor(className);
var FreshComponent = React.createElement(FreshConstructor, props);

ReactDOM[renderFunctionName](React.createElement(AppContainer, null, FreshComponent), node);
var nodes = findAllReactNodes(className);
for (var i = 0; i < nodes.length; ++i) {
var reactNode = nodes[i];
ReactDOM[renderFunctionName](React.createElement(AppContainer, null, FreshComponent), reactNode);
}
});

ReactDOM[renderFunctionName](React.createElement(AppContainer, null, component), node);
Expand All @@ -34,3 +38,12 @@ function getFileNameFromClassName(className) {

return filename;
}

function findAllReactNodes(className) {
var selector = '[' + ReactRailsUJS.CLASS_NAME_ATTR + '="' + className + '"]';
if (ReactRailsUJS.jQuery) {
return ReactRailsUJS.jQuery(selector, document);
} else {
return parent.querySelectorAll(selector);
}
}