Expose all built-in options for getConstructor #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| @HarrisonB can you rebase this on master? |
Contributor Author
| Sure! I'll hopefully get to it in the next week or two |
hibachrach force-pushed the add-additional-options-for-getConstructor branch from ee7a0f4 to 332667d Compare Contributor Author
| @justin808 updated! |
Collaborator
| @HarrisonB can you confirm that all unit tests run locally? Currently, we don't have CI working. We need to move to GH Actions. |
Contributor Author
| Having some trouble--See #1198 (comment) |
Collaborator
| @hibachrach is this ready for merge? |
Contributor Author
| yes, though we should have it trigger CI to make sure it passes. is there a way to do that on your end? |
Collaborator
| @hibachrach did you rebase on master where the github actions are defined? |
Quoting reactjs#264 (comment) > Regarding `Encountered error "#<ExecJS::ProgramError: Invariant > Violation: Element type is invalid: ...`: > > I think one of the core issues is that [module lookup uses > `try...catch`](https://github.com/reactjs/react-rails/blob/master/react_ujs/src/getConstructor/fromRequireContextWithGlobalFallback.js#L11-L23). > While the errors are logged to the console shim, that typically doesn't > help as a later error (such as the invariant violation) will lead to a > fatal error (triggering a 500). If that could be refactored to be a bit > more intentional based on environment (instead of just reacting based on > exceptions, or at the very least, throwing if the caught exception isn't > very specific) This enables us to easily override `getConstructor` to not use global fallback, avoiding the all-consuming `try...catch`.
hibachrach force-pushed the add-additional-options-for-getConstructor branch from 332667d to 9aabc79 Compare Contributor Author
| Tests are now passing! |
Collaborator
| @justin808 The PR is good to go if we have no review comments. |
Collaborator
| Thanks @hibachrach! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
This enables us to easily override
getConstructorto not use globalfallback, avoiding the all-consuming
try...catch.Other Information
Here's the context:
Quoting #264 (comment)