fix(typebox): improve type interface #757
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
resolve #753 (comment)
Unlike other resolvers like
zod, which can take Input, Context, and Output as generic arguments, it is not feasible to achieve a similar interface withtypebox.suggested type:
rationale:
typebox, theTObjecttype acceptsTPropertiesas an argument, which differs from theInput(FieldValues) concept in other resolvers.Input(FieldValues) would result in a type error:If we attempted to replicate the interface seen in zod, it would require defining the schema type explicitly as a generic parameter, which is not practical or realistic for users:
Given these constraints, the initially proposed typing is the most feasible approach for
typebox. It prioritizes usability while maintaining type safety.