[ci-skip][doc] Update steps for emails_controller_test.rb in sign_up_and_settings.md #55996
+27 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rafaelfranca added a commit that referenced this pull request Oct 24, 2025
[ci-skip][doc] Update steps for emails_controller_test.rb in sign_up_and_settings.md
hachi8833 added a commit to yasslab/railsguides.jp that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because some steps to write tests need improvements.
Detail
This Pull Request changes:
SessionTestHelperto be consistent with 8-1-stabletest/fixtures/users.ymlbecause the tests ("validates current password" and "sends email confirmation on successful update") depend on the updatedtest/fixtures/users.ymlwith first and last names to pass validations. If the first/last names are missing intest/fixtures/users.yml, the tests fail.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]