Add success_callback to Action Cable's stream_from and stream_to #55824 
     +65   −5      
   Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.    
 
Motivation / Background
Action Cable channels have a
success_callbackthat is used in the implementation ofstream_fromandstream_to, which is used to ensure that streams subscriptions are established before the channel subscription confirmation is sent to the client.👉🏻 This changes
stream_fromandstream_toto expose their ownsuccess_callbacktoo. This callback can be used in Channels to defer behavior until the stream subscription is established.For example, a channel might want to ensure there aren't any missed updates between when a record is fetched and rendered for the frontend, and when an Action Cable stream subscription is ultimately established:
Additional information
I think this is conceptually a good change because it better aligns Stream subscription lifecycle options with Channel subscription lifecycle options.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]