Skip to content

Conversation

@p8
Copy link
Member

@p8 p8 commented Jan 9, 2024

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.
Copy link

@brendanh-katalyst brendanh-katalyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@p8
Copy link
Member Author

p8 commented Jan 12, 2024

@p8 p8 merged commit 8944d80 into rails:main Jan 12, 2024
@p8 p8 deleted the activerecord/values-at-example branch January 12, 2024 10:58
yoones pushed a commit to yoones/rails that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment