Skip to content

Avoid extra array allocation for where(x: [...]) #49991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

Avoid extra array allocation for where(x: [...]) #49991

merged 1 commit into from
Nov 9, 2023

Conversation

@jonathanhefner
Copy link
Member

@jonathanhefner jonathanhefner commented Nov 9, 2023

We do not need to construct an array of nils; we merely need to determine whether any are present in the values array and remove them. Thus, we can use compact! instead of extract!.
@jonathanhefner
Avoid extra array allocation for where(x: [...])
ebd9661 
We do not need to construct an array of `nil`s; we merely need to determine whether any are present in the values array and remove them. Thus, we can use `compact!` instead of `extract!`.
@jonathanhefner jonathanhefner merged commit 6828546 into rails:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

activerecord

1 participant

@jonathanhefner