Don't pass active_record to derive_fk_query_constraints #49255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We already have access to the `active_record` on the reflection here so there's no point in passing it to `derive_fk_query_constraints`. In addition the id, fk check wasn't actually doing anything here, it was holdover from debugging I was doing when implementing this functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We already have access to the
active_recordon the reflection here so there's no point in passing it toderive_fk_query_constraints.In addition the id, fk check wasn't actually doing anything here, it was holdover from debugging I was doing when implementing this functionality.